Skip to content

Populate make_classification_df date functionality with random dates #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Populate make_classification_df date functionality with random dates #851

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b55f9a
fix populates make_classification_df with random dates
BhuvanashreeM Aug 29, 2021
424fca4
added-seed-to-random_date-and-modified-test_datasets
BhuvanashreeM Aug 31, 2021
b740b27
check-for-unique-values
BhuvanashreeM Sep 3, 2021
24461fb
checks-for-random_state-type
BhuvanashreeM Sep 3, 2021
3a7c9d1
removed-redundant-compute-calls-in-random_date
BhuvanashreeM Sep 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dask_ml/datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,8 +451,8 @@ def make_classification_df(
[
X_df,
dd.from_array(
np.array([random_date(*dates)] * len(X_df)),
chunksize=chunks,
np.array([random_date(*dates) for i in range(len(X_df))]),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some test errors because random_dates doesn't have a random seed. Maybe this signature would help?

def random_dates(start, end, random_state=None):
    rng = check_random_state(random_state)
    ...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that could be a probable reason, I'll work on it. And also, the test written for the function(make_classification_df) doesn't check for true randomness. I'm thinking of adding a new test/modifying the existing one for the same, will that suffice?
link to test_make_classification_df

chunksize=n_samples,
columns=["date"],
),
],
Expand Down