Skip to content

Conversation

crusaderky
Copy link
Contributor

@crusaderky crusaderky commented Jan 30, 2025

dask/dask#11706

Closes data-apis/array-api-tests#338

Also clean up a wealth of XPASS

@crusaderky crusaderky marked this pull request as draft January 30, 2025 17:55
@crusaderky crusaderky closed this Jan 30, 2025
@crusaderky crusaderky reopened this Jan 30, 2025
@crusaderky crusaderky marked this pull request as ready for review January 30, 2025 20:37
@crusaderky
Copy link
Contributor Author

@ev-br ready for review

Copy link
Member

@ev-br ev-br left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cleanup of dark xfails is both very welcome and scary: some (many?) of these can be flaky tests. That said, undoing them en masse and re enabling those which do show up is a valid strategy, let's do this.
And we do need an xfail for the arange test which blocks the world.
Thanks @crusaderky

@ev-br ev-br merged commit 6e897a1 into data-apis:main Jan 31, 2025
84 checks passed
@crusaderky crusaderky deleted the da_arange branch January 31, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: test_arange() fails on Dask due to illegal dtype

2 participants