Skip to content

Conversation

crusaderky
Copy link
Contributor

No description provided.

@crusaderky crusaderky closed this Jan 30, 2025
@crusaderky crusaderky reopened this Jan 30, 2025
@crusaderky crusaderky marked this pull request as ready for review January 31, 2025 09:25
@crusaderky crusaderky changed the title WIP numpy XPASS cleanup TST: numpy XPASS cleanup Jan 31, 2025
@crusaderky
Copy link
Contributor Author

@ev-br ready for review

@ev-br
Copy link
Member

ev-br commented Jan 31, 2025

Now that you touched numpy versions :-), there's something strange. Numpy-dev requires python >=3.11 (cf numpy/numpy@688669f), how come CI passes with numpy-dev and python==3.10 at https://github.com/data-apis/array-api-compat/actions/runs/13061139491/job/36444175360?pr=247

This should probably be cleaned up, too.

@crusaderky
Copy link
Contributor Author

@ev-br done. An admin needs to update the expected checks in the project settings.

@ev-br
Copy link
Member

ev-br commented Jan 31, 2025

An admin needs to update the expected checks in the project settings.

Thanks! That'd be @rgommers, I suspect.

@kgryte
Copy link
Contributor

kgryte commented Feb 3, 2025

@crusaderky and @ev-br I've removed the obsolete CI status checks. This PR should now be ready to merge.

@ev-br ev-br merged commit 7948ac0 into data-apis:main Feb 3, 2025
40 checks passed
@crusaderky crusaderky deleted the numpy-xpass branch February 5, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants