-
Notifications
You must be signed in to change notification settings - Fork 16
MAINT: update lock file to unblock CI #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jorenham any advice for the NumPy dtype typing failures that have appeared upon upgrading mypy? |
array-api-extra/tests/test_funcs.py Line 226 in c94a47f
array-api-extra/tests/test_funcs.py Line 242 in c94a47f
|
You're comparing a |
So the problem is that we're annotating |
is |
A scalar type. |
Ah ok, then array-api-extra/tests/test_funcs.py Line 217 in c94a47f
should instead be |
BTW, hypothesis also has a dedicated strategy for this: https://hypothesis.readthedocs.io/en/latest/reference/strategies.html#hypothesis.extra.numpy.floating_dtypes It's for |
Sounds like we should use that then! |
thanks, I think 11d5472 should do it |
No description provided.