ENH: atleast_nd delegation
#454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascolley
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
looks great, I agree that this delegation strategy makes sense, thanks @Enderdead !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request introduces the
atleast_nddelegate function (#100).Unlike other delegate functions,
atleast_nddoes not exist for all major backends. Instead, the functionsatleast_1d,atleast_2d, andatleast_3dare available.In this implementation, I use
getattrto delegate when ndim is between 1 and 3. I’ve also added tests with ndim=3 to cover the full range.Open to feedback!