Skip to content

WIP ENH: setdiff1d delegate function #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP ENH: setdiff1d delegate function #456

wants to merge 1 commit into from
+56 −39

Conversation

Enderdead
Copy link
Contributor

@Enderdead Enderdead commented Oct 2, 2025 •
edited
Loading

This merge request introduces the setdiff1d delegate function (#100).

Nothing special to mention here — it was NOT a straightforward contribution.

@Enderdead Enderdead marked this pull request as draft October 2, 2025 15:16
@lucascolley lucascolley self-requested a review October 2, 2025 16:15
@lucascolley lucascolley added this to the 0.9.1 milestone Oct 2, 2025
@lucascolley lucascolley added enhancement New feature or request delegation labels Oct 2, 2025
@Enderdead Enderdead changed the title ENH: setdiff1d delegate function WIP ENH: setdiff1d delegate function Oct 2, 2025
lucascolley
lucascolley reviewed Oct 3, 2025
View reviewed changes
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see also #124

@Enderdead
Copy link
Contributor Author

Enderdead commented Oct 7, 2025 •
edited
Loading

Two issues have been identified during the development of the JAX part (see jax-ml/jax#32335 and jax-ml/jax#32402 )

I will finish my contribution once all the issues have been reported to the JAX library.

@Enderdead
Copy link
Contributor Author

According to my understanding of the work discussed in #124, the JAX JIT version has been postponed indefinitely, but the Dask version is still desired. Since the function setdiff1d is not available in the Dask API (see Dask NumPy compatibility), the implementation proposed by @crusaderky seems worth pushing forward.

Because this implementation differs from a classic delegate function (as it introduces a new approach), where should I place the dedicated code for Dask? Alternatively, do we want to replace the current version, which uses the _helpers.in1d method, with @crusaderky’s implementation?

@lucascolley
Copy link
Member

I'm not sure about how to proceed for Dask and JAX, but I would be happy to review a PR which just adds delegation for the other libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucascolley lucascolley lucascolley left review comments

Assignees
No one assigned
Labels
delegation enhancement New feature or request
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Enderdead @lucascolley