Skip to content

Fix test_take to make axis optional when ndim == 1 #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix test_take to make axis optional when ndim == 1 #192

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca44b2a
Fix test_take to make axis optional when ndim == 1
asmeurer Jul 15, 2023
f60471a
Skip flaky `test_bitwise_xor`
honno Feb 28, 2024
91dc500
Merge branch 'master' into take-fix
lucascolley Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions array_api_tests/test_indexing_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,22 @@ def test_take(x, data):
# * negative axis
# * negative indices
# * different dtypes for indices
axis = data.draw(st.integers(0, max(x.ndim - 1, 0)), label="axis")

# axis is optional but only if x.ndim == 1
_axis_st = st.integers(0, max(x.ndim - 1, 0))
if x.ndim == 1:
kw = data.draw(hh.kwargs(axis=_axis_st))
else:
kw = {"axis": data.draw(_axis_st)}
axis = kw.get("axis", 0)
_indices = data.draw(
st.lists(st.integers(0, x.shape[axis] - 1), min_size=1, unique=True),
label="_indices",
)
indices = xp.asarray(_indices, dtype=dh.default_int)
note(f"{indices=}")

out = xp.take(x, indices, axis=axis)
out = xp.take(x, indices, **kw)

ph.assert_dtype("take", in_dtype=x.dtype, out_dtype=out.dtype)
ph.assert_shape(
Expand Down