Skip to content

Fix some TODOs for test_repeat() #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fix some TODOs for test_repeat() #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 39 additions & 14 deletions array_api_tests/test_manipulation_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,45 @@ def test_permute_dims(x, axes):
out_indices=permuted_indices)


@pytest.mark.min_version("2023.12")
@given(
x=hh.arrays(dtype=hh.all_dtypes, shape=shared_shapes(min_dims=1)),
kw=hh.kwargs(
axis=st.none() | shared_shapes(min_dims=1).flatmap(
lambda s: st.integers(-len(s), len(s) - 1)
)
),
data=st.data(),
)
def test_repeat(x, kw, data):
shape = x.shape
axis = kw.get("axis", None)
dim = math.prod(shape) if axis is None else shape[axis]
repeat_strat = st.integers(1, 4)
repeats = data.draw(repeat_strat
| hh.arrays(dtype=hh.int_dtypes, elements=repeat_strat,
shape=st.sampled_from([(1,), (dim,)])),
label="repeats")
if isinstance(repeats, int):
n_repitions = dim*repeats
else:
if repeats.shape == (1,):
n_repitions = dim*repeats[0]
else:
n_repitions = int(xp.sum(repeats))

out = xp.repeat(x, repeats, **kw)
ph.assert_dtype("repeat", in_dtype=x.dtype, out_dtype=out.dtype)
if axis is None:
expected_shape = (n_repitions,)
else:
expected_shape = list(shape)
expected_shape[axis] = n_repitions
expected_shape = tuple(expected_shape)
ph.assert_shape("repeat", out_shape=out.shape, expected=expected_shape)
# TODO: values testing


@st.composite
def reshape_shapes(draw, shape):
size = 1 if len(shape) == 0 else math.prod(shape)
Expand All @@ -298,20 +337,6 @@ def reshape_shapes(draw, shape):
return tuple(rshape)


@pytest.mark.min_version("2023.12")
@given(
x=hh.arrays(dtype=hh.all_dtypes, shape=hh.shapes(min_dims=1)),
repeats=st.integers(1, 4),
)
def test_repeat(x, repeats):
# TODO: test array repeats and non-None axis, adjust shape and value testing accordingly
out = xp.repeat(x, repeats)
ph.assert_dtype("repeat", in_dtype=x.dtype, out_dtype=out.dtype)
expected_shape = (math.prod(x.shape) * repeats,)
ph.assert_shape("repeat", out_shape=out.shape, expected=expected_shape)
# TODO: values testing


@pytest.mark.unvectorized
@pytest.mark.skip("flaky") # TODO: fix!
@given(
Expand Down
Loading