Skip to content

stop skipping test_divide for complex inputs #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

stop skipping test_divide for complex inputs #306

merged 1 commit into from
Nov 18, 2024

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented Nov 16, 2024

Address the test_divide (no complex numbers testing) part of #301

Locally tests seem to pass, so I actually wonder what was meant by the TODO comment.

@asmeurer
Copy link
Member

Not sure. It was added in ff865bc. It's possible my fix at aba096e using cmath instead of math was all that was needed.

@asmeurer asmeurer merged commit 393b69b into data-apis:master Nov 18, 2024
4 checks passed
@ev-br ev-br mentioned this pull request Nov 19, 2024
Open
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ev-br @asmeurer