Skip to content

MAINT: simplify the count_nonzero strategy #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

MAINT: simplify the count_nonzero strategy #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions array_api_tests/test_searching_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,6 @@ def test_argmin(x, data):
ph.assert_scalar_equals("argmin", type_=int, idx=out_idx, out=min_i, expected=expected)


# XXX: dtype= stanza below is to work around unsigned int dtypes in torch
# (count_nonzero_cpu not implemented for uint32 etc)
# XXX: the strategy for x is problematic on JAX unless JAX_ENABLE_X64 is on
# the problem is tha for ints >iinfo(int32) it runs into essentially this:
# >>> jnp.asarray[2147483648], dtype=jnp.int64)
Expand All @@ -99,7 +97,7 @@ def test_argmin(x, data):
@pytest.mark.min_version("2024.12")
@given(
x=hh.arrays(
dtype=st.sampled_from(dh.int_dtypes + dh.real_float_dtypes + dh.complex_dtypes + (xp.bool,)),
dtype=hh.all_dtypes,
shape=hh.shapes(min_dims=1, min_side=1),
elements={"allow_nan": False},
),
Expand Down