Skip to content

test_clip: make sure min and max have the same dtype as x #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

test_clip: make sure min and max have the same dtype as x #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions array_api_tests/test_operators_and_elementwise_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,17 +987,15 @@ def test_clip(x, data):
base_shape=x.shape),
label="min.shape, max.shape")

dtypes = hh.real_floating_dtypes if dh.is_float_dtype(x.dtype) else hh.int_dtypes

min = data.draw(st.one_of(
st.none(),
hh.scalars(dtypes=st.just(x.dtype)),
Copy link
Contributor

@crusaderky crusaderky Apr 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this misses out on the use case clip(Array[float], int)
#364

hh.arrays(dtype=dtypes, shape=shape1),
hh.arrays(dtype=st.just(x.dtype), shape=shape1),
), label="min")
max = data.draw(st.one_of(
st.none(),
hh.scalars(dtypes=st.just(x.dtype)),
hh.arrays(dtype=dtypes, shape=shape2),
hh.arrays(dtype=st.just(x.dtype), shape=shape2),
), label="max")

# min > max is undefined (but allow nans)
Expand Down