Skip to content

BUG: allow max_dimensions to be None #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

BUG: allow max_dimensions to be None #378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions array_api_tests/test_inspection_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,14 @@ def test_capabilities(self):

expected_attr = {"boolean indexing": bool, "data-dependent shapes": bool}
if xp.__array_api_version__ >= "2024.12":
expected_attr.update(**{"max dimensions": int})
expected_attr.update(**{"max dimensions": type(None) | int})

for attr, typ in expected_attr.items():
assert attr in capabilities, f'capabilites is missing "{attr}".'
assert isinstance(capabilities[attr], typ)

assert capabilities.get("max dimensions", 100500) > 0
max_dims = capabilities.get("max dimensions", 100500)
assert (max_dims is None) or (max_dims > 0)

def test_devices(self):
out = xp.__array_namespace_info__()
Expand Down