Skip to content

ENH: expand testing of meshgrid #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ev-br wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ENH: expand testing of meshgrid #405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions array_api_tests/test_creation_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,8 +538,12 @@ def test_linspace(num, dtype, endpoint, data):
raise


@given(dtype=hh.numeric_dtypes, data=st.data())
def test_meshgrid(dtype, data):
@given(
dtype=hh.numeric_dtypes,
kw=hh.kwargs(indexing=st.sampled_from(["xy", "ij"])),
data=st.data()
)
def test_meshgrid(dtype, kw, data):
# The number and size of generated arrays is arbitrarily limited to prevent
# meshgrid() running out of memory.
shapes = data.draw(
Expand All @@ -557,11 +561,17 @@ def test_meshgrid(dtype, data):
# sanity check
# assert math.prod(math.prod(x.shape) for x in arrays) <= hh.MAX_ARRAY_SIZE

repro_snippet = ph.format_snippet(f"xp.meshgrid(*arrays) with {arrays = }")
tgt_shape = [a.shape[0] for a in arrays]
if len(tgt_shape) > 1 and kw.get('indexing', 'xy') == 'xy':
tgt_shape[0], tgt_shape[1] = tgt_shape[1], tgt_shape[0]
tgt_shape = tuple(tgt_shape)

repro_snippet = ph.format_snippet(f"xp.meshgrid(*arrays, **kw) with {arrays = } and {kw = }")
try:
out = xp.meshgrid(*arrays)
out = xp.meshgrid(*arrays, **kw)
for i, x in enumerate(out):
ph.assert_dtype("meshgrid", in_dtype=dtype, out_dtype=x.dtype, repr_name=f"out[{i}].dtype")
ph.assert_shape("meshgrid", out_shape=x.shape, expected=tgt_shape)
except Exception as exc:
ph.add_note(exc, repro_snippet)
raise
Expand Down