Skip to content

test: fix CI and unfinalize HasArrayNamespace #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 18, 2025
Merged

test: fix CI and unfinalize HasArrayNamespace #29

merged 7 commits into from
Jun 18, 2025

Conversation

nstarman
Copy link
Collaborator

@nstarman nstarman commented Jun 17, 2025 •
edited
Loading

Fixes #26

@nstarman nstarman requested a review from jorenham June 17, 2025 06:16
@nstarman
test: fix missing docs folder
a41f4ed 
Signed-off-by: Nathaniel Starkman <[email protected]>
jorenham
jorenham reviewed Jun 17, 2025
View reviewed changes
Copy link
Member

@jorenham jorenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the protocol in the tests that inherits from HasArrayNamespace the only reason for removing the @final?

@nstarman
Copy link
Collaborator Author

is the protocol in the tests that inherits from HasArrayNamespace the only reason for removing the @Final?

That and Array(HasArrayNamespace, Protocol)

jorenham
jorenham reviewed Jun 17, 2025
View reviewed changes
@nstarman
ci: pin pytest and bump pytest-cov
e9ae1f3 
Signed-off-by: Nathaniel Starkman <[email protected]>
@nstarman nstarman marked this pull request as ready for review June 17, 2025 16:09
@nstarman @jorenham
style: add trailing newline
7b0b162 
Co-authored-by: Joren Hammudoglu <[email protected]>
Signed-off-by: Nathaniel Starkman <[email protected]>
@jorenham jorenham enabled auto-merge (squash) June 18, 2025 13:58
@jorenham jorenham merged commit 204c20a into main Jun 18, 2025
14 checks passed
@jorenham jorenham deleted the fix_ci branch June 18, 2025 13:59
@jorenham
Copy link
Member

Thanks @nstarman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorenham jorenham jorenham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI failures on main
2 participants
@nstarman @jorenham