Merge pull request #294 from data-integrations/CDAP-19532

katukota-google · web-flow · commit 315223088ba8 · 2022-09-21T14:42:29.000-07:00
CDAP-19532 | allow precision 0 for Oracle Number data type in generic database plugin - Fix tests
diff --git a/database-commons/src/test/java/io/cdap/plugin/db/CommonSchemaReaderTest.java b/database-commons/src/test/java/io/cdap/plugin/db/CommonSchemaReaderTest.java
@@ -154,7 +154,7 @@ public void testGetSchemaHandlesBytes() throws SQLException {
     Assert.assertEquals(Schema.of(Schema.Type.BYTES), reader.getSchema(metadata, 4));
   }
 
-  @Test(expected = SQLException.class)
+  @Test(expected = IllegalArgumentException.class)
   public void testGetSchemaThrowsExceptionOnNumericWithZeroPrecision() throws SQLException {
     when(metadata.getColumnType(eq(1))).thenReturn(Types.NUMERIC);
     when(metadata.getPrecision(eq(1))).thenReturn(0);

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ public void testGetSchemaHandlesBytes() throws SQLException {`
`154`	`154`	`Assert.assertEquals(Schema.of(Schema.Type.BYTES), reader.getSchema(metadata, 4));`
`155`	`155`	`}`
`156`	`156`
`157`		`- @Test(expected = SQLException.class)`
	`157`	`+ @Test(expected = IllegalArgumentException.class)`
`158`	`158`	`public void testGetSchemaThrowsExceptionOnNumericWithZeroPrecision() throws SQLException {`
`159`	`159`	`when(metadata.getColumnType(eq(1))).thenReturn(Types.NUMERIC);`
`160`	`160`	`when(metadata.getPrecision(eq(1))).thenReturn(0);`