Skip to content

Conversation

@psainics
Copy link
Contributor

@psainics psainics commented Jan 13, 2025

Error Management catch known errors [GCSCopy]

Jira : PLUGIN-1841

Description

  • Remove unused imports
  • Error Management catch known errors

Code change

  • Modified GCSCopy.java.java

Test

  • Test Case (File does not exist on path provided)
Raw Logs
2025-01-13 13:16:17,350 - ERROR [WorkflowDriver:i.c.c.i.a.r.w.WorkflowProgramController@90] - Workflow service 'workflow.default.GCS_COPY_TEST_RUN.DataPipelineWorkflow.714f70f0-d182-11ef-88e1-00000036fa10' failed.
io.cdap.cdap.api.exception.WrappedStageException: Stage 'GCS Copy' encountered : io.cdap.cdap.etl.api.validation.ValidationException: Errors were encountered during validation. Failed to create storage client, unable to load service account credentials. /Users/pusaini/cbin/cred/GCP_invalid.json (No such file or directory)
  at io.cdap.cdap.etl.common.plugin.ExceptionWrappingCaller.call(ExceptionWrappingCaller.java:64)
  at io.cdap.cdap.etl.common.plugin.WrappedAction.run(WrappedAction.java:48)
  at io.cdap.cdap.etl.batch.customaction.PipelineAction.run(PipelineAction.java:91)
  at io.cdap.cdap.internal.app.runtime.AbstractContext.execute(AbstractContext.java:608)
  at io.cdap.cdap.internal.app.runtime.workflow.CustomActionExecutor.execute(CustomActionExecutor.java:90)
  at io.cdap.cdap.internal.app.runtime.workflow.WorkflowDriver.executeCustomAction(WorkflowDriver.java:449)
  at io.cdap.cdap.internal.app.runtime.workflow.WorkflowDriver.executeNode(WorkflowDriver.java:489)
  at io.cdap.cdap.internal.app.runtime.workflow.WorkflowDriver.executeAll(WorkflowDriver.java:669)
  at io.cdap.cdap.internal.app.runtime.workflow.WorkflowDriver.run(WorkflowDriver.java:653)
  at com.google.common.util.concurrent.AbstractExecutionThreadService$1$1.run(AbstractExecutionThreadService.java:52)
  at java.lang.Thread.run(Thread.java:750)
Caused by: io.cdap.cdap.etl.api.validation.ValidationException: Errors were encountered during validation. Failed to create storage client, unable to load service account credentials. /Users/pusaini/cbin/cred/GCP_invalid.json (No such file or directory)
  at io.cdap.cdap.etl.validation.DefaultFailureCollector.getOrThrowException(DefaultFailureCollector.java:78)
  at io.cdap.cdap.etl.validation.LoggingFailureCollector.getOrThrowException(LoggingFailureCollector.java:50)
  at io.cdap.plugin.gcp.gcs.actions.GCSCopy.run(GCSCopy.java:73)
  at io.cdap.cdap.etl.common.plugin.WrappedAction.lambda$run$1(WrappedAction.java:49)
  at io.cdap.cdap.etl.common.plugin.Caller$1.call(Caller.java:30)
  at io.cdap.cdap.etl.common.plugin.ExceptionWrappingCaller.call(ExceptionWrappingCaller.java:62)
  ... 10 common frames omitted

POST v3/namespaces/{namespace-id}/apps/{app-id}/workflows/DataPipelineWorkflow/runs/{run-id}/classify
[
{
  "stageName": "GCS Copy",
  "errorCategory": "Plugin-'Validation'-'GCS Copy'",
  "errorReason": "Stage 'GCS Copy' encountered 1 validation failures.",
  "errorMessage": "Stage 'GCS Copy' encountered : io.cdap.cdap.etl.api.validation.ValidationException: Errors were encountered during validation. Failed to create storage client, unable to load service account credentials. /Users/pusaini/cbin/cred/GCP_invalid.json (No such file or directory)",
  "errorType": "USER",
  "dependency": "false"
}
]

image
image

@psainics psainics added the build Trigger unit test build label Jan 13, 2025
@psainics psainics self-assigned this Jan 13, 2025
@psainics psainics marked this pull request as ready for review January 13, 2025 10:56
}
StorageClient storageClient = StorageClient.create(config.getProject(), config.getServiceAccount(),
isServiceAccountFilePath, config.readTimeout);
StorageClient storageClient = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StorageClient is plugin class, please also cover that.

@psainics psainics merged commit a03238f into data-integrations:develop Jan 21, 2025
15 of 16 checks passed
@psainics psainics deleted the fem/action/GCSCopy branch January 21, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Trigger unit test build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants