-
Notifications
You must be signed in to change notification settings - Fork 86
Removing verify tag #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing verify tag #1578
Conversation
cf96a1e to
1bcea03
Compare
itsankit-google
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change?
The reason is that when the verify goal is used and the build fails due to a test failure, the Cucumber reports were still getting generated but not showing any test failures. This made it difficult to identify what exactly failed. And i checked with other repo's we have commented out this in most of the repo's as well. |
I don't see it commented out in database-plugins repo? |
|
Can you explain more how this helps in fixing the issue? |
|
In my opinion, The failsafe:verify goal was causing the build to terminate early on test failures, before Cucumber could generate its final report. This led to a situation where the Cucumber report incorrectly showed all tests as passed. By removing the verify goal, the build completes even if some tests fail, allowing Cucumber to generate accurate reports that include all test outcomes — both passed and failed. |
pom.xml
Outdated
| <goals> | ||
| <goal>integration-test</goal> | ||
| <goal>verify</goal> | ||
| <!-- <goal>verify</goal>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a comment for disabling this check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
1bcea03 to
83a9b1c
Compare
This PR contains change to remove verify tag from pom.xml to get correct build details and cucumber reports.