Skip to content

Conversation

@AnkitCLI
Copy link
Contributor

@AnkitCLI AnkitCLI commented Aug 4, 2025

This PR contains change to remove verify tag from pom.xml to get correct build details and cucumber reports.

@AnkitCLI AnkitCLI added the build Trigger unit test build label Aug 4, 2025
@AnkitCLI AnkitCLI force-pushed the RemovingVerifyTag branch from cf96a1e to 1bcea03 Compare August 4, 2025 09:04
@AnkitCLI AnkitCLI marked this pull request as ready for review August 4, 2025 10:10
Copy link
Contributor

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

@AnkitCLI
Copy link
Contributor Author

AnkitCLI commented Aug 4, 2025

why this change?

The reason is that when the verify goal is used and the build fails due to a test failure, the Cucumber reports were still getting generated but not showing any test failures. This made it difficult to identify what exactly failed. And i checked with other repo's we have commented out this in most of the repo's as well.

@itsankit-google
Copy link
Contributor

why this change?

The reason is that when the verify goal is used and the build fails due to a test failure, the Cucumber reports were still getting generated but not showing any test failures. This made it difficult to identify what exactly failed. And i checked with other repo's we have commented out this in most of the repo's as well.

I don't see it commented out in database-plugins repo?

@AnkitCLI
Copy link
Contributor Author

AnkitCLI commented Aug 5, 2025

why this change?

The reason is that when the verify goal is used and the build fails due to a test failure, the Cucumber reports were still getting generated but not showing any test failures. This made it difficult to identify what exactly failed. And i checked with other repo's we have commented out this in most of the repo's as well.

I don't see it commented out in database-plugins repo?
We are also facing some issues in DB repo. This issue is when build fails no cucumber report would be generated. Currently looking into it.
But if we you see in salesforce and hydrator repo's you will see the tag is removed. In starting in google cloud also the tag is commented out. https://github.com/data-integrations/salesforce/blob/develop/pom.xml. https://github.com/cdapio/hydrator-plugins/blob/develop/pom.xml

@itsankit-google
Copy link
Contributor

why this change?

The reason is that when the verify goal is used and the build fails due to a test failure, the Cucumber reports were still getting generated but not showing any test failures. This made it difficult to identify what exactly failed. And i checked with other repo's we have commented out this in most of the repo's as well.

I don't see it commented out in database-plugins repo?
We are also facing some issues in DB repo. This issue is when build fails no cucumber report would be generated. Currently looking into it.
But if we you see in salesforce and hydrator repo's you will see the tag is removed. In starting in google cloud also the tag is commented out. https://github.com/data-integrations/salesforce/blob/develop/pom.xml. https://github.com/cdapio/hydrator-plugins/blob/develop/pom.xml

Can you explain more how this helps in fixing the issue?

@AnkitCLI
Copy link
Contributor Author

AnkitCLI commented Aug 5, 2025

In my opinion, The failsafe:verify goal was causing the build to terminate early on test failures, before Cucumber could generate its final report. This led to a situation where the Cucumber report incorrectly showed all tests as passed. By removing the verify goal, the build completes even if some tests fail, allowing Cucumber to generate accurate reports that include all test outcomes — both passed and failed.

pom.xml Outdated
<goals>
<goal>integration-test</goal>
<goal>verify</goal>
<!-- <goal>verify</goal>-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment for disabling this check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@AnkitCLI AnkitCLI force-pushed the RemovingVerifyTag branch from 1bcea03 to 83a9b1c Compare August 5, 2025 05:31
@AnkitCLI AnkitCLI merged commit 6cdd47c into data-integrations:develop Aug 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Trigger unit test build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants