Merged
Conversation
AnkitCLI
force-pushed
the
driveE2E
branch
9 times, most recently
from
df2d108 to
e1b9ad1
Compare
| Feature: Google Drive Batch Source - Runtime Scenarios | ||
|
|
||
| @BATCH-TS-GD-MACRO-01 @BQ_SINK_TEST | ||
| Scenario: Validate successful records transfer from GoogleDrive to BigQuery with macro arguments |
Contributor
There was a problem hiding this comment.
I don't see this scenario in cucumber reports?
Contributor
Author
There was a problem hiding this comment.
Added some new steps for macro feature. Now you will able to see in the report as well.
AnkitCLI
force-pushed
the
driveE2E
branch
2 times, most recently
from
d53cbe2 to
fd69463
Compare
pom.xml
Outdated
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <version>2.18.1</version> |
Contributor
There was a problem hiding this comment.
Please move version to properties.
pom.xml
Outdated
| <plugin> | ||
| <groupId>org.codehaus.mojo</groupId> | ||
| <artifactId>build-helper-maven-plugin</artifactId> | ||
| <version>3.3.0</version> |
Contributor
There was a problem hiding this comment.
Same comment for the whole pr.
Contributor
Author
There was a problem hiding this comment.
done for whole PR.
Contributor
itsankit-google
left a comment
itsankit-google
left a comment
There was a problem hiding this comment.
Why are we not creating the Gdrive directory and files within the e2e test?
E2E tests are written for other plugins in a way that the source / destination credentials can be changed and they should work. This dependency on existing Gdrive defeats that purpose.
itsankit-google
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains e2e test cases for google drive source plugin including locators, actions and stepdesigns classes.