SF e2e test fixes #276
Merged
SF e2e test fixes #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkitCLI
force-pushed
the
e2e-test-fixes
branch
3 times, most recently
from
005d6b1 to
4d73f95
Compare
AnkitCLI
requested review from
itsankit-google and
ritwiksahani
and removed request for
itsankit-google
ritwiksahani
requested changes
May 8, 2025
ritwiksahani
left a comment
ritwiksahani
left a comment
There was a problem hiding this comment.
Please add details in the description around what E2E test is failing and details around what changes we are doing to fix it.
AnkitCLI
force-pushed
the
e2e-test-fixes
branch
3 times, most recently
from
20ce8d9 to
e29559e
Compare
ritwiksahani
reviewed
May 8, 2025
src/e2e-test/features/salesforcemultiobjectsbatchsource/RunTime.feature
Outdated
Show resolved
Hide resolved
AnkitCLI
force-pushed
the
e2e-test-fixes
branch
4 times, most recently
from
6b25d30 to
05534f0
Compare
ritwiksahani
approved these changes
May 9, 2025
ritwiksahani
left a comment
ritwiksahani
left a comment
There was a problem hiding this comment.
Please ensure that e2e tests are now successful after this change.
| logger.info("Queried Object id from response: " + uniqueRecordId); | ||
| String id = recordObject.get("Id").getAsString(); | ||
| idList.add(id); | ||
| logger.info("Queried Object id from response: " + idList); |
There was a problem hiding this comment.
We should not be logging idList every time. Pelase change this log to id.
| public void updateExistingSalesforceRecords() { | ||
| String uniqueRecordId = SalesforceClient.queryObjectId(customObject); | ||
| SalesforceClient.updateObject(uniqueRecordId, customObject); | ||
| List<String> uniqueRecordId = SalesforceClient.queryObjectId(customObject); |
There was a problem hiding this comment.
rename the variable to recordIdList/recordIds.
AnkitCLI
force-pushed
the
e2e-test-fixes
branch
2 times, most recently
from
d1e84e8 to
532feb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the fixes for salesforce e2e tests by updating the schema for sObjects and fixing the data validation logic to validate all the records from salesforce and BQ. Previously it was fetching only one record from salesforce.