Moved the pk chunking check to SplitUtil class #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| SalesforceBulkUtil.awaitCompletion(bulkConnection, job, Collections.singletonList(batchInfo), true); | ||
| } | ||
|
|
||
| @Test |
Contributor
There was a problem hiding this comment.
Add a UT to validate that there are no entries with the upper case values.
|
|
||
| // This is added for UCS use case only to identify the objects where PK chunking needs to be enabled by default. | ||
| public static boolean isPkChunkingSupported(String sobjectName) { | ||
| return sobjectName != null && ( |
Contributor
There was a problem hiding this comment.
Add a check for empty sObjectName
Contributor
There was a problem hiding this comment.
Better break this check into multiple cases for better readability.
vikasrathee-cs
force-pushed
the
pk-chunk-check-dev
branch
from
31fbdc7 to
771edba
Compare
MrRahulSharma
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the pk chunking check to SplitUtil class