[PLUGIN-1902] Changes done for schema backward compatibility along with metadata API addition for DTS #110

vikasrathee-cs · 2025-07-17T05:01:25Z

[PLUGIN-1902 Changes done for schema backward compatibility along with metadata API addition for DTS](#100)

src/main/java/io/cdap/plugin/servicenow/apiclient/ServiceNowTableAPIClientImpl.java

sahusanket · 2025-08-14T21:05:56Z

Any reason why model is inside sink ? Is it not used by validation and source?

If no strong reason then please refactor it to io.cdap.plugin.servicenow.model

src/main/java/io/cdap/plugin/servicenow/sink/model/ServiceNowSchemaField.java

sahusanket · 2025-08-14T21:24:23Z

I see a lot of Old code that was used for SCHEMA API , is not used to MetaData APi instead ?

Is that expected? and why ?

vikasrathee-cs · 2025-08-18T09:58:44Z

I see a lot of Old code that was used for SCHEMA API , is not used to MetaData API instead ?
Is that expected? and why ?

Previously Schema API was removed and same classes were used for Metadata API, later due to backward compatibility we had to add schema api again. Renamed the classes again to provide the clarity on which class getting used by which api.

sahusanket · 2025-08-19T19:57:58Z

src/main/java/io/cdap/plugin/servicenow/apiclient/ServiceNowTableAPIClientImpl.java


-    if (schemaResponse.getResult() == null && schemaResponse.getResult().getColumns().isEmpty()) {
-      throw new RuntimeException("Error - Schema Response does not contain any result");
+    if (schemaType == SchemaType.METADATA_API_BASED) {


In case of DTS it directly calls this method ?

sahusanket · 2025-08-19T20:09:36Z

src/main/java/io/cdap/plugin/servicenow/apiclient/ServiceNowTableAPIRequestBuilder.java

+                                          SchemaType schemaType) {
    if (isSchemaRequired) {
-      this.setUrl(String.format(METADATA_API_URL_TEMPLATE, instanceBaseUrl, tableName));
+      if (SchemaType.METADATA_API_BASED == schemaType) {


Please simplify this

move this.setUrl(String.format(TABLE_API_URL_TEMPLATE, instanceBaseUrl, tableName)); before the if block as the default

sahusanket · 2025-08-19T20:29:48Z

src/main/java/io/cdap/plugin/servicenow/apiclient/ServiceNowTableAPIClientImpl.java

-  public ServiceNowTableAPIClientImpl(ServiceNowConnectorConfig conf) {
+  public ServiceNowTableAPIClientImpl(ServiceNowConnectorConfig conf, Boolean useConnection) {
    this.conf = conf;
+    this.useConnection = useConnection;


Do we still need this field ?

no, removed.

src/main/java/io/cdap/plugin/servicenow/ServiceNowBaseConfig.java

sahusanket · 2025-08-20T17:56:41Z

Please squash before merging.

vikasrathee-cs added the build label Jul 17, 2025

vikasrathee-cs force-pushed the backward-compatability-schema-fix branch from b24f5ed to fa9c399 Compare July 17, 2025 05:42

vikasrathee-cs requested a review from prince-cs July 18, 2025 05:47

vikasrathee-cs force-pushed the backward-compatability-schema-fix branch from 4ac51bd to a69805b Compare July 18, 2025 07:56

vikasrathee-cs requested a review from sahusanket July 18, 2025 07:57

vikasrathee-cs force-pushed the backward-compatability-schema-fix branch from a69805b to a3b768a Compare July 25, 2025 12:16

vikasrathee-cs force-pushed the backward-compatability-schema-fix branch from a3b768a to e5f72f3 Compare August 4, 2025 09:54