Skip to content

Conversation

@prince-cs
Copy link
Contributor

@prince-cs prince-cs commented Jun 5, 2025

Current Issue:
It has been observed that when the display value type is selected, some values that are defined as integers in the schema appear as strings.

Code Changes:
The changes are made on how the schema is fetched. The API associated for fetching the schema is changed to use the column metadata api which now fetches the schema.
Schema API: baseUrl/api/now/doc/table/schema/tableName
Column Metadata API: baseUrl/api/now/ui/meta/tableName

In accordance with the response from the column metadata API, the SchemaResponse class is also changed to accommodate the changes. Before mapping the datatype, a check is applied that if the value type is display and if there is a mismatch between the internal_type and type then it needs to be mapped to the type otherwise internal_type.

Testing:
The code changes are verified by running unit tests and e2e tests. Also, did run the pipelines for some of the tables for Display and Actual value type.

JIRA Ticket: https://cdap.atlassian.net/browse/PLUGIN-1895

Copy link
Contributor

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add some description in the PR,

with brief explanation under three subheadings:

  • What is the current issue?

  • What are the changes?

  • How the changes are tested?

This will help reviewers understand the change and review PRs efficiently.

Also please create a JIRA and attached to every PR raised to open-source public repos.

@itsankit-google
Copy link
Contributor

Also please don;t add reviewers until all these builds are green :
image

@prince-cs prince-cs changed the title Fixing datatype mismatch issue when value type is display [PLUGIN-1895] Fixing datatype mismatch issue when value type is display Jun 6, 2025
@prince-cs prince-cs force-pushed the bugfix-display-datatype-mismatch branch from 5d37f27 to 83da0d4 Compare June 11, 2025 06:41
@prince-cs prince-cs merged commit 2c981e0 into develop Jun 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants