"[PLUGIN-1901] Time datatype support for actual value type" #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubhangi-cs
force-pushed
the
bugfix/time_dataType
branch
from
ec75721 to
3dc91fb
Compare
Shubhangi-cs
force-pushed
the
bugfix/time_dataType
branch
from
3dc91fb to
d1b43ad
Compare
Shubhangi-cs
changed the title
|
Can you please add more details(What and Why, testing details) in the description. Also e2e tests are failing for this PR |
Contributor
Author
Added, working on e2e |
prince-cs
reviewed
Jun 27, 2025
| columns.add(new ServiceNowColumn(field.getName(), field.getType())); | ||
| } else if (valueType.equals(SourceValueType.SHOW_ACTUAL_VALUE) && | ||
| "glide_time".equalsIgnoreCase(field.getInternalType())) { | ||
| columns.add(new ServiceNowColumn(field.getName(), "datetime")); |
Contributor
There was a problem hiding this comment.
this should be glide_date_time
prince-cs
reviewed
Jun 27, 2025
| case "glide_date": | ||
| return Schema.of(Schema.LogicalType.DATE); | ||
| case "glide_date_time": | ||
| case "datetime": |
Contributor
There was a problem hiding this comment.
This can be omitted. As, we can use glide_date_time
Shubhangi-cs
force-pushed
the
bugfix/time_dataType
branch
from
d1b43ad to
f6ce966
Compare
Sunish-Dahiya
requested changes
Jul 7, 2025
| !Objects.equals(field.getType(), field.getInternalType())) { | ||
| columns.add(new ServiceNowColumn(field.getName(), field.getType())); | ||
| } else if (valueType.equals(SourceValueType.SHOW_ACTUAL_VALUE) && | ||
| "glide_time".equalsIgnoreCase(field.getInternalType())) { |
There was a problem hiding this comment.
Please move "glide_time" to constants
| columns.add(new ServiceNowColumn(field.getName(), field.getType())); | ||
| } else if (valueType.equals(SourceValueType.SHOW_ACTUAL_VALUE) && | ||
| "glide_time".equalsIgnoreCase(field.getInternalType())) { | ||
| columns.add(new ServiceNowColumn(field.getName(), "glide_date_time")); |
Shubhangi-cs
force-pushed
the
bugfix/time_dataType
branch
from
f6ce966 to
cdcd55d
Compare
Sunish-Dahiya
approved these changes
Jul 7, 2025
| private static final String FIELD_CREATED_ON = "sys_created_on"; | ||
| private static final String FIELD_UPDATED_ON = "sys_updated_on"; | ||
| private static final String OAUTH_URL_TEMPLATE = "%s/oauth_token.do"; | ||
| private static final String GLIDE_TIME = "glide_time"; |
There was a problem hiding this comment.
[nit]: Adding a DATA_TYPE as prefix or suffix would make it more readable
Shubhangi-cs
force-pushed
the
bugfix/time_dataType
branch
from
cdcd55d to
b636e77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: for fields of type
glide_timein ServiceNow, when the value is retrieved using theactualvalue type, it is returned in aglide_datetimeformat. This causes a parsing failure, as the expected format forglide_timeis not maintained. However, when using thedisplayvalue type, the value is correctly returned asglide_time.Root Cause: ServiceNow automatically prefixes a default date to
glide_timevalues when accessed via theactualvalue type, converting it todatetimeformat.Fix: implemented explicit handling to map
glide_timefields todatetimewhen using theactualvalue type.JIRA Ticket: https://cdap.atlassian.net/browse/PLUGIN-1901