[PLUGIN-1832] Error Management Snowflake Source and Sink, fix sonar issues, and added new Validation and fix bugs for maximum split size and NPE issue handled #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/io/cdap/plugin/snowflake/common/SnowflakeErrorDetailsProvider.java
Outdated
Show resolved
Hide resolved
Amit-CloudSufi
force-pushed
the
snowFlakeError
branch
from
1fd1285 to
756fb99
Compare
src/main/java/io/cdap/plugin/snowflake/sink/batch/SnowflakeSinkAccessor.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/sink/batch/StructuredRecordToCSVRecordTransformer.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/sink/batch/SnowflakeOutputFormat.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/sink/batch/SnowflakeRecordWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/source/batch/SnowflakeBatchSource.java
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/sink/batch/SnowflakeBatchSink.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/source/batch/SnowflakeBatchSourceConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/source/batch/SnowflakeBatchSourceConfig.java
Outdated
Show resolved
Hide resolved
sahusanket
reviewed
Dec 27, 2024
src/main/java/io/cdap/plugin/snowflake/common/SnowflakeErrorDetailsProvider.java
Outdated
Show resolved
Hide resolved
sahusanket
reviewed
Dec 27, 2024
sahusanket
reviewed
Dec 27, 2024
sahusanket
reviewed
Dec 27, 2024
src/main/java/io/cdap/plugin/snowflake/source/batch/SnowflakeMapToRecordTransformer.java
Outdated
Show resolved
Hide resolved
|
What is the new |
src/main/java/io/cdap/plugin/snowflake/common/client/SnowflakeAccessor.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/common/client/SnowflakeAccessor.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/common/util/DocumentUrlUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/sink/batch/StructuredRecordToCSVRecordTransformer.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/sink/batch/StructuredRecordToCSVRecordTransformer.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/sink/batch/SnowflakeOutputFormat.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/sink/batch/SnowflakeSinkAccessor.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/common/client/SnowflakeAccessor.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/common/SnowflakeErrorType.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/sink/batch/SnowflakeSinkAccessor.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/sink/batch/StructuredRecordToCSVRecordTransformer.java
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/source/batch/SnowflakeMapToRecordTransformer.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/source/batch/SnowflakeSourceAccessor.java
Outdated
Show resolved
Hide resolved
Contributor
itsankit-google
left a comment
itsankit-google
left a comment
There was a problem hiding this comment.
Please add screenshot as evidences of response returned from error classification api in PR description.
src/main/java/io/cdap/plugin/snowflake/common/SnowflakeErrorType.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/sink/batch/SnowflakeOutputFormat.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/sink/batch/SnowflakeRecordWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/source/batch/SnowflakeSourceAccessor.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/common/client/SnowflakeAccessor.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/snowflake/common/SnowflakeErrorType.java
Outdated
Show resolved
Hide resolved
itsankit-google
approved these changes
Jan 9, 2025
…for maximum split size and NPE issue handled
Amit-CloudSufi
force-pushed
the
snowFlakeError
branch
from
f30eb01 to
fcd56b5
Compare
Contributor
itsankit-google
left a comment
itsankit-google
left a comment
There was a problem hiding this comment.
please add evidence of testing in PR description before merge.
psainics
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIra : https://cdap.atlassian.net/browse/PLUGIN-1832
Scenario is Wrong username or Password is provided.
