Skip to content

Additional e2e scenarios for Wrangler#724

Merged
AnkitCLI merged 1 commit intodata-integrations:developfrom
cloudsufi:Additional-e2e-wrangler
Jan 23, 2025
Merged

Additional e2e scenarios for Wrangler#724
AnkitCLI merged 1 commit intodata-integrations:developfrom
cloudsufi:Additional-e2e-wrangler

Conversation

@AnkitCLI
Copy link
Contributor

@AnkitCLI AnkitCLI commented Jan 17, 2025 •
edited
Loading

This PR contains additional E2E scenarios for Wrangler Plugin

@AnkitCLI AnkitCLI force-pushed the Additional-e2e-wrangler branch from 32e5b6f to 2eb7a76 Compare January 17, 2025 05:45
@AnkitCLI AnkitCLI added the build Triggers unit test build label Jan 17, 2025
@AnkitCLI AnkitCLI force-pushed the Additional-e2e-wrangler branch 3 times, most recently from caae1f4 to cb6459d Compare January 17, 2025 12:55
@AnkitCLI AnkitCLI marked this pull request as ready for review January 17, 2025 12:57
itsankit-google
itsankit-google reviewed Jan 22, 2025
View reviewed changes
wrangler-transform/src/e2e-test/features/WranglerErrorScenarios.feature Outdated
@@ -0,0 +1,76 @@
# Copyright © 2023 Cask Data, Inc.
Copy link
Contributor

@itsankit-google itsankit-google Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2025

Copy link
Contributor Author

@AnkitCLI AnkitCLI Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

wrangler-transform/src/e2e-test/features/Wrangler_Macro.feature Outdated
@@ -0,0 +1,83 @@
# Copyright © 2024 Cask Data, Inc.
Copy link
Contributor

@itsankit-google itsankit-google Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2025

Copy link
Contributor Author

@AnkitCLI AnkitCLI Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

itsankit-google
itsankit-google reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to see Verify Wrangler Plugin Error scenarios in the cucumber report:
image

@AnkitCLI AnkitCLI force-pushed the Additional-e2e-wrangler branch 2 times, most recently from bd0fb25 to 85f7453 Compare January 22, 2025 06:04
@AnkitCLI
Copy link
Contributor Author

AnkitCLI commented Jan 22, 2025 •
edited
Loading

I am not able to see Verify Wrangler Plugin Error scenarios in the cucumber report: image

This is because the tag was Wrangler_Required so we are not able to see in this report. Change is done so now it will reflect here.

@itsankit-google
Copy link
Contributor

itsankit-google commented Jan 22, 2025

This is because the tag was Wrangler_Required so we are not able to see in this report. Change is done so now it will reflect here.

Required tests should run both times when all tests are run, changing the tag will make not run when we have to run required tests, right?

@AnkitCLI
Copy link
Contributor Author

AnkitCLI commented Jan 22, 2025 •
edited
Loading

This is because the tag was Wrangler_Required so we are not able to see in this report. Change is done so now it will reflect here.

Required tests should run both times when all tests are run, changing the tag will make not run when we have to run required tests, right?

This is because the tag was Wrangler_Required so we are not able to see in this report. Change is done so now it will reflect here.

Required tests should run both times when all tests are run, changing the tag will make not run when we have to run required tests, right?

Yes correct added the tag so that run with required and run all e2e tests as well.

@AnkitCLI AnkitCLI force-pushed the Additional-e2e-wrangler branch 3 times, most recently from 9cc7162 to d28f9fb Compare January 22, 2025 12:32
@AnkitCLI AnkitCLI force-pushed the Additional-e2e-wrangler branch from d28f9fb to c81b5b8 Compare January 23, 2025 03:24
@AnkitCLI AnkitCLI merged commit 0f6e1b4 into data-integrations:develop Jan 23, 2025
5 checks passed
Vishwash123 pushed a commit to Vishwash123/wrangler that referenced this pull request Apr 13, 2025
@AnkitCLI
Merge pull request data-integrations#724 from cloudsufi/Additional-e2…
cd566fa 
…e-wrangler

Additional e2e scenarios for Wrangler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsankit-google itsankit-google itsankit-google approved these changes

Assignees

No one assigned

Labels

build Triggers unit test build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AnkitCLI @itsankit-google