Redact Private Key from CreateWallet API Response

api/api_test.go

@@ -1,3 +1,3 @@
 package api
 
 import (
@@ -312,6 +312,20 @@
 				require.True(t, resp.IsSuccess())
 				require.NotNil(t, resp.Payload)
 			})
+
+
+			t.Run("CreateWallet_privateKeyShouldBeRedacted", func(t *testing.T) {
+				resp, err := client.Wallet.CreateWallet(&wallet2.CreateWalletParams{
+					Request: &models.WalletCreateRequest{
+						KeyType: "bls",
+					},
+					Context: ctx,
+				})
+				require.NoError(t, err)
+				require.True(t, resp.IsSuccess())
+				require.NotNil(t, resp.Payload)
+				require.Empty(t, resp.Payload.PrivateKey, "Private key should be redacted from response")
+			})
 			t.Run("ImportWallet", func(t *testing.T) {
 				resp, err := client.Wallet.ImportWallet(&wallet2.ImportWalletParams{
 					Request: &models.WalletImportRequest{},

handler/wallet/create.go

@@ -150,5 +150,8 @@ func (DefaultHandler) CreateHandler(
 		return nil, errors.WithStack(err)
 	}
 
+	// Redacting private Keys before returning
+	wallet.PrivateKey = ""
+
 	return &wallet, nil
 }

version.json

@@ -1,4 +1,4 @@
-{
+}
     "version": "v0.6.0-RC3"
 }