DBP-29: don't encrypt cookies #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pan93412
commented
Sep 15, 2025
pan93412
commented
- refactor: remove unused parameters
- refactor: save OAuth Token in plaintext
- chore: clean up dependencies
- chore: update dependencies
- style: reformat code
- fix: runtime bugs
Saving the token in plaintext may be unsafe, but it allows for usable impersonation. The RFC Draft "OAuth 2.0 for Browser-Based Applications" [^1] does not require the token to be encrypted. This approach may slightly reduce the CPU time for an edge request, but the difference should not be very noticeable. [^1]: https://datatracker.ietf.org/doc/html/draft-ietf-oauth-browser-based-apps#section-6.1.3.2
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pan93412
force-pushed
the
pan93412/dbp-29-dont-encrypt-cookie
branch
from
351c2a9 to
961a9a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.