This repository was archived by the owner on Oct 15, 2025. It is now read-only.
Improve Challenge #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pan93412
commented
Nov 14, 2024
pan93412
commented
- fix(docker): Clear Meilisearch index before re-indexing
- refactor: Rewrite DbRunner and Challenge page
- refactor: Remove unused strings
- feat(challenge): Add "diff presenter" back
- refactor(challenge): Make AnswerQueryResult static
- fix(challenge): Update events when the new query submitted
* Typed query result: We previously returned the raw "array" and type-hinted them everywhere. Now, the DbRunner returns a QueryResultDto that wraps this type. * Improved "Result Presenter": Instead of passing the result everywhere, retrieve it directly in the tabs rather than receiving it from the Executor. * The executor now creates a new SolutionEvent without comparing the results. * Added a new Comparer that provides more comprehensive difference information. * Removed "Module" from the component namespace. * Update DbRunner return style * All the cells are string now * The first row is header * The rows started from the second are the rows
It seldom changes.
Make ColumnsOfAnswer deferred.
The query will not update to Live Component model now, so we should get the query from the last query. Besides, I remove the writable query model as it is completely unused now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.