Skip to content

Conversation

@pan93412
Copy link
Member

  • test: remove redundant rank resolver test
  • feat(graph): return score in RankingEdge
  • feat(ranking): return score in RankingEdge

@pan93412 pan93412 self-assigned this Oct 13, 2025
@linear
Copy link

linear bot commented Oct 13, 2025

@pan93412 pan93412 merged commit df278d3 into main Oct 13, 2025
2 checks passed
@pan93412 pan93412 deleted the pan93412/dbp-107-需要顯示點數增加數 branch October 13, 2025 19:06
@pan93412 pan93412 requested a review from Copilot October 13, 2025 19:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds score display functionality to the ranking system by including a Score field in the RankingEdge type, allowing the frontend to display point increases or completion counts for each ranked user.

Key changes:

  • Added Score field to RankingEdge in GraphQL schema and model
  • Updated ranking service to populate the score field
  • Removed redundant rank resolver test file and added comprehensive score-focused tests

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
graph/rank.graphqls Added score: Int! field to RankingEdge type
graph/model/models_gen.go Generated model includes new Score field
internal/ranking/ranking.go Populates Score field from user score data
internal/ranking/ranking_test.go Added comprehensive tests for score functionality
graph/rank_resolver_test.go Removed redundant test file

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants