Skip to content

feat: Add Meta configurations support in Tenant #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hantmac merged 3 commits into from
Dec 19, 2024
Merged

feat: Add Meta configurations support in Tenant #18

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c364a22
chore(tenant): finish verify meta.
Electronic-Waste Dec 19, 2024
8459eaa
fix(lint): fix lint error.
Electronic-Waste Dec 19, 2024
40b9bd0
fix(lint): remove defer.
Electronic-Waste Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions pkg/controller/tenant/tenant_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ import (
"context"
"errors"
"fmt"
"net"
"time"

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/aws/credentials"
Expand Down Expand Up @@ -48,6 +50,8 @@ const (
builtinUserError opState = iota
)

const DefaultTimeout = time.Second * 10

// TenantReconciler reconciles a Tenant object
type TenantReconciler struct {
client.Client
Expand All @@ -72,6 +76,7 @@ func (r *TenantReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
originStatus := tenant.Status.DeepCopy()

// Verify storage configuration
log.V(5).Info("Verifying storage configurations")
opState, storageErr := r.verifyStorage(ctx, &tenant)
if storageErr != nil {
err = errors.Join(err, storageErr)
Expand All @@ -80,13 +85,15 @@ func (r *TenantReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
setCondition(&tenant, opState)

// Verify meta configuration
log.V(5).Info("Verifying meta configurations")
opState, metaErr := r.verifyMeta(ctx, &tenant)
if metaErr != nil {
err = errors.Join(err, metaErr)
}
setCondition(&tenant, opState)

// Verify built-in users configuration
log.V(5).Info("Verifying built-in users configurations")
opState, userErr := r.verifyBuiltinUsers(ctx, &tenant)
if userErr != nil {
err = errors.Join(err, userErr)
Expand Down Expand Up @@ -147,6 +154,35 @@ func (r *TenantReconciler) verifyStorage(ctx context.Context, tenant *databendv1
}

func (r *TenantReconciler) verifyMeta(ctx context.Context, tenant *databendv1alpha1.Tenant) (opState, error) {
log := ctrl.LoggerFrom(ctx)

if len(tenant.Spec.Meta.Endpoints) == 0 {
return metaError, fmt.Errorf("missing meta endpoints, at lease 1")
}

// Check meta connections
metaConfig := tenant.Spec.Meta
for _, endpoint := range metaConfig.Endpoints {
conn, err := net.DialTimeout("tcp", endpoint, DefaultTimeout)
if err != nil {
return metaError, fmt.Errorf("failed to dial to %s, %w", endpoint, err)
}
_ = conn.Close()
}

// Check secrets
if metaConfig.MetaAuth.PasswordSecretRef != nil {
log.V(5).Info("Getting meta password from secret")
var secret corev1.Secret
nn := types.NamespacedName{
Namespace: metaConfig.MetaAuth.PasswordSecretRef.Namespace,
Name: metaConfig.MetaAuth.PasswordSecretRef.Name,
}
if err := r.Get(ctx, nn, &secret, &client.GetOptions{}); err != nil {
return storageError, fmt.Errorf("failed to get secret %v", nn)
}
}

return creationSucceeded, nil
}

Expand Down
Loading