feat: Add Tenant and Warehouse CRD. #2
Conversation
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
| // Region of S3 storage. | ||
| Region string `json:"region,omitempty"` | ||
|
|
||
| // Endpoint of S3 storage. |
There was a problem hiding this comment.
add an optional for the endpoint? when you're using s3, endpoint is not an required parameter in most of the time.
There was a problem hiding this comment.
It's optional now, since I added omitempty tag after the field.
Electronic-Waste
left a comment
Electronic-Waste
left a comment
There was a problem hiding this comment.
@flaneur2020 @hantmac I left some comments. Please let me know your ideas about them:)
| // Password encrypted with AuthType. | ||
| AuthString string `json:"authString,omitempty"` |
There was a problem hiding this comment.
I was wondering, whether we need to add a field named AuthStringRef to reference Secret like what we do in S3 and meta configurations.
There was a problem hiding this comment.
i feel having a reference to secret is nice, might be like support both of styles:
authString:
value: "a md5 hash"
authString:
secretRef:
name: "blah"
namespace: "xxx"
There was a problem hiding this comment.
I think so. What about maintaining consistency with S3 and Meta configs? I think it would be better if we add a new field named AuthStringRef. WDYT👀？
There was a problem hiding this comment.
What about maintaining consistency with S3 and Meta configs? I think it would be better if we add a new field named AuthStringRef. WDYT👀？
looks good to me 👍
pkg/api/v1alpha1/warehouse_types.go
Outdated
| // Time for Query clsuter to suspend when no query requests are received. | ||
| // +kubebuilder:default=1500 | ||
| AutoSuspendAfterSecs int `json:"autoSuspendAfterSecs,omitempty"` |
There was a problem hiding this comment.
This field is not found in helm-charts. I'm also wondering whether we need to support this feature now or implement it in the next version of databend-operator.
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
3 participants
This PR adds fields and annotations to:
cc👀 @flaneur2020 @hantmac