Skip to content

Conversation

@everpcpc
Copy link
Member

Summary

  • Replaced the old builder-style helpers in SessionState with mutable setters and updated the core client’s DSN parser to use them directly.
  • Added runtime setter methods (set_warehouse, set_database, set_role, set_session) on APIClient and exposed matching APIs on the driver Connection.
  • Extended the driver’s IConnection trait so REST connections wire through to the core client while FlightSQL connections return explicit “unavailable” errors for these new operations.

@everpcpc everpcpc requested a review from youngsofun December 18, 2025 03:25
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@everpcpc
Copy link
Member Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@everpcpc everpcpc merged commit 35bea8b into databendlabs:main Dec 18, 2025
42 checks passed
@everpcpc everpcpc deleted the fix-set branch December 18, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants