Skip to content

Conversation

@youngsofun
Copy link
Member

@youngsofun youngsofun commented Aug 22, 2025

new features:

  1. FileTransferAPI add new interface
public interface FileTransferAPI {
   /**
     * Upload inputStream into the target table
     *
     * @param sql the sql with syntax `Insert into <table> [(<columns></columns>) [values (?, ...)]] from @_databend_load [file_format=(...)]`
     * @param inputStream the input stream of the file
     * @param loadMethod one of "stage" or "streaming"
     * @return num of rows loaded
     * @throws SQLException fail to load file into table
     */
    int loadStreamToTable(String sql, InputStream inputStream, long fileSize, String loadMethod) throws SQLException;
}
  1. support login and capabilities
  2. add docs about FileTransferAPI

ci

  1. add compitibility test
  2. use docker compose to start cluster for tests, like in bendsql, so it easier to test locally ( old cluster tests removed), configfile is a littel diff from bendsql is that multi host test need diff ports to know which node is used and diff discovery_addrs.
  3. fix some tests with no asserts.
  4. fix test about settings.
  5. update server version
  6. fix some warnings
  7. test cluster behind nginx.

refactors:

  1. unify retry logic of login/logout/heartbeat/streaming_load, not supporting multihost for now
  2. move some class from client package to jdbc
  3. polish pom.xml

@youngsofun youngsofun force-pushed the fix branch 3 times, most recently from 8ec0d70 to 8ea4e28 Compare August 25, 2025 01:42
@youngsofun youngsofun requested a review from hantmac August 25, 2025 01:57
@youngsofun
Copy link
Member Author

cc @sundy-li

@youngsofun youngsofun force-pushed the fix branch 2 times, most recently from e162ea0 to 2b1ea4f Compare August 26, 2025 11:08
@youngsofun youngsofun force-pushed the fix branch 2 times, most recently from bb6663e to c2c81af Compare August 27, 2025 02:10
@youngsofun
Copy link
Member Author

@sundy-li @ZhiHanZ fail of Code Quality Check is a known issue, please ignore it , the pr is ready to review

Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngsofun youngsofun merged commit 649c29e into databendlabs:main Aug 29, 2025
9 of 10 checks passed
@hantmac hantmac mentioned this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants