Skip to content

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Aug 14, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore(query):

  1. Improve error of project_column_ref, use error instead of unwrap panic
  2. Remove databend-local cause it's useless
  3. Add some tests of regexp_replace

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Aug 14, 2025
@sundy-li sundy-li marked this pull request as ready for review August 14, 2025 13:47
@sundy-li sundy-li requested a review from b41sh August 15, 2025 07:45
@zhang2014
Copy link
Member

Please merge after #18268.

Copy link
Member

@zhang2014 zhang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@sundy-li sundy-li requested a review from zhang2014 August 18, 2025 07:14
@sundy-li sundy-li merged commit a77953f into databendlabs:main Aug 18, 2025
225 of 234 checks passed
@sundy-li sundy-li deleted the project_column_ref-improve branch August 18, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants