Skip to content

fix(query): prevent stack overflow in CTE processing with recursive annotations #18588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2025
Merged

fix(query): prevent stack overflow in CTE processing with recursive annotations #18588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/query/sql/src/planner/binder/bind_query/bind.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ impl CTERefCounter {
}

impl Binder {
#[recursive::recursive]
pub(crate) fn bind_query(
&mut self,
bind_context: &mut BindContext,
Expand Down Expand Up @@ -119,6 +120,7 @@ impl Binder {
Ok(())
}

#[recursive::recursive]
pub fn compute_cte_ref_count(
&self,
with: &With,
Expand Down Expand Up @@ -209,6 +211,7 @@ impl Binder {
))
}

#[recursive::recursive]
pub fn m_cte_to_temp_table(
&mut self,
cte: &CTE,
Expand Down Expand Up @@ -345,6 +348,7 @@ impl TableNameReplacer {
}
}

#[recursive::recursive]
fn enter_table_reference(&mut self, table_reference: &mut TableReference) {
if let TableReference::Table {
database, table, ..
Expand All @@ -356,6 +360,7 @@ impl TableNameReplacer {
}
}

#[recursive::recursive]
fn enter_expr(&mut self, expr: &mut Expr) {
if let Expr::ColumnRef { column, .. } = expr {
if column.database.is_none() || column.database.as_ref().unwrap().name == self.database
Expand Down
1 change: 1 addition & 0 deletions src/query/sql/src/planner/binder/bind_table_reference/bind_cte.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ impl Binder {
Ok((s_expr, new_bind_context))
}

#[recursive::recursive]
pub fn bind_cte_definition(
&mut self,
cte_name: &str,
Expand Down
Loading