refactor: refactor partition stream in aggregation spiller #19158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dqhl76
changed the title
github-actions
bot
added
the
pr-refactor
dqhl76
changed the title
dqhl76
commented
Dec 25, 2025
| self.finish_count = 0; | ||
|
|
||
| let ids = self.partition_stream.partition_ids(); | ||
| pub struct LocalPartitionStream { |
Collaborator
Author
There was a problem hiding this comment.
Since the new final aggregator handles partitioned(isolate) data, we can remove the lock on the shared partition stream to reduce contention.
| } | ||
| } | ||
|
|
||
| pub struct NewAggregateSpillReader { |
Collaborator
Author
There was a problem hiding this comment.
Split a reader from the spiller. It does not need to create partition stream.
Collaborator
Author
|
included in #19155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This is part of #19155 (part 2)
Refactor new aggregate spiller streams and add a spill reader, deprecating the unused max_partition_count in restored payloads.
Extract aggregate-function descriptor building into a shared helper for final aggregate planning.
Tests
Type of change
This change is