fix: join panic while executing delete stmt #19266
Draft
+194
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantengsky
force-pushed
the
fix-del-join-panic
branch
from
0a5bc51 to
7fdaddb
Compare
dantengsky
changed the title
Mutation planning was passing planner metadata column indexes (including internal columns like _block_name) as Fuse table schema field indexes, which could cause TableSchema::project() to index out of bounds during DELETE. Convert mutation read columns to base column_positions (schema FieldIndex), carry internal columns separately, and generate them from block_meta_index at execution time for filter evaluation.
dantengsky
force-pushed
the
fix-del-join-panic
branch
from
7fdaddb to
2610f44
Compare
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
fixes join panic which executing delete stmt :
(Code: 1068, Text = Cannot join handle from context's runtime, cause: PanicError. Code: 1104, Text = index out of bounds)
to be detailed
Tests
Type of change
This change is