Skip to content

Conversation

@zhyass
Copy link
Member

@zhyass zhyass commented Jan 24, 2026

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jan 24, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec68a8fad5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +120 to +123
fn create(func_name: &str, table_args: TableArgs) -> Result<Self>
where Self: Sized {
let (database_name, table_name) = parse_db_tb_args(&table_args, func_name)?;
Ok(Self {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore single-arg copy_history support

This now uses parse_db_tb_args, which requires exactly two arguments (database, table). Before this change, copy_history('t') defaulted to the current database and even allowed copy_history('db.table'); with the new signature those existing usages (including the test tests/sqllogictests/suites/mode/cluster/distributed_copy_into_table.test using copy_history('t')) will raise BadArguments, breaking backward compatibility for users and CI. Consider accepting one argument and defaulting to the current database (e.g., via parse_db_tb_opt_args or explicit fallback) while still parsing the optional /branch suffix.

Useful? React with 👍 / 👎.

@zhyass zhyass marked this pull request as draft January 24, 2026 16:19
@github-actions
Copy link
Contributor

🤖 CI Job Analysis

Workflow: 21317807089

📊 Summary

  • Total Jobs: 84
  • Failed Jobs: 5
  • Retryable: 0
  • Code Issues: 5

NO RETRY NEEDED

All failures appear to be code/test issues requiring manual fixes.

🔍 Job Details

  • linux / test_unit: Not retryable (Code/Test)
  • linux / test_private_tasks: Not retryable (Code/Test)
  • linux / sqllogic / ee (parquet): Not retryable (Code/Test)
  • linux / sqllogic / cluster (cluster, 2c, hybrid): Not retryable (Code/Test)
  • linux / sqllogic / cluster (cluster, 2c, http): Not retryable (Code/Test)

🤖 About

Automated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant