feat: add sandbox env injection case via cloud control#19383
Open
KKould wants to merge 7 commits intodatabendlabs:mainfrom
Open
feat: add sandbox env injection case via cloud control#19383KKould wants to merge 7 commits intodatabendlabs:mainfrom
KKould wants to merge 7 commits intodatabendlabs:mainfrom
Conversation
Member
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b8e258c54
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
🤖 CI Job Analysis (Retry 1)
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
The previous Resource interface in this PR was relatively simple and limited. It has since been expanded into separate Create / List / Alter / Delete interfaces and renamed to Worker. The syntax design also takes inspiration from CREATE WAREHOUSE (https://docs.databend.com/sql/sql-commands/ddl/warehouse/create-warehouse
), which is conceptually similar to our warehouse abstraction.
As with the earlier Resource design, each Worker corresponds to a single UDF, and the cloud starts the corresponding worker based on the function name.
Originally, ENV was intended to be passed via tags, similar to CREATE WAREHOUSE. However, due to the security risks of transmitting environment variables in plaintext, ENV configuration is now managed by the cloud instead.
example:
Tips:
At the moment, the experience of using environment variables in Sandbox UDFs may feel somewhat fragmented. After creating a UDF, users still need to manually configure the environment variables in the cloud, which is an area that could be improved.
Tests
Type of change
This change is