refactor(config): dedup query config inner/outer#19446
Merged
dantengsky merged 4 commits intodatabendlabs:mainfrom Feb 11, 2026
Merged
refactor(config): dedup query config inner/outer#19446dantengsky merged 4 commits intodatabendlabs:mainfrom
dantengsky merged 4 commits intodatabendlabs:mainfrom
Conversation
SkyFan2002
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
outer::QueryConfigintoinner::QueryConfig.commoncommonlayer)tenant_id,node_id,node_secret, builtin/settings), and access configurable fields explicitly viaquery.common.*Design Choice
Deref/DerefMutfrom inner config to outer config.Derefis idiomatic mainly for pointer-like wrappers; using it here would blur domain boundaries between runtime-only and user-configurable fields.query.common.*access keeps field ownership and data source clear, improves readability/grep-ability, and makes future refactors safer.DerefMutalso prevents implicit mutable access paths that are easy to misuse in a large codebase.Tests
Type of change
This change is