feat(query): extend tag support to view, udf, and procedure objects#19447
feat(query): extend tag support to view, udf, and procedure objects#19447TCeason wants to merge 1 commit intodatabendlabs:mainfrom
Conversation
github-actions
bot
added
the
pr-feature
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fe72c991a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/query/service/src/table_functions/tag_references/tag_references_table.rs
Show resolved
Hide resolved
TCeason
force-pushed
the
tag_object-2
branch
from
6fe72c9 to
618097f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 618097fd04
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/query/service/src/table_functions/tag_references/tag_references_table.rs
Outdated
Show resolved
Hide resolved
TCeason
force-pushed
the
tag_object-2
branch
2 times, most recently
from
1f70d70 to
04b3613
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04b3613e0f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/query/service/src/interpreters/interpreter_procedure_drop.rs
Outdated
Show resolved
Hide resolved
TCeason
force-pushed
the
tag_object-2
branch
from
393c857 to
9571d84
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9571d846af
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/query/service/src/table_functions/tag_references/tag_references_table.rs
Outdated
Show resolved
Hide resolved
TCeason
force-pushed
the
tag_object-2
branch
from
9571d84 to
04ce9bb
Compare
Add ALTER VIEW/FUNCTION/PROCEDURE SET/UNSET TAG syntax and wire it
through all layers: AST parser, binder (with proper type resolution
via generate_procedure_name_ident), plan, interpreter, privilege
check, access log, and tag_references table function.
- View reuses TaggableObject::Table (views share table ID space)
- UDF/Procedure add new TaggableObject variants with name-based keys
- Add parse_procedure_ref() to common_ast for consistent procedure
reference parsing with type normalization
- Add tag cleanup on UDF/Procedure drop
- Add sqllogic tests for end-to-end validation
TCeason
force-pushed
the
tag_object-2
branch
from
04ce9bb to
b18bb44
Compare
2 participants
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Add ALTER VIEW/FUNCTION/PROCEDURE SET/UNSET TAG syntax and wire it
through all layers: AST parser, binder (with proper type resolution
via generate_procedure_name_ident), plan, interpreter, privilege
check, access log, and tag_references table function.
Tests
Type of change
This change is