feat(test): display query_id on sqllogictest failure#19528
Open
dqhl76 wants to merge 4 commits intodatabendlabs:mainfrom
Open
feat(test): display query_id on sqllogictest failure#19528dqhl76 wants to merge 4 commits intodatabendlabs:mainfrom
dqhl76 wants to merge 4 commits intodatabendlabs:mainfrom
Conversation
forsaken628
reviewed
Mar 16, 2026
Member
|
How to ensure the tests quality for each commit if they were move to another repo? |
0d4b294 to
f746719
Compare
Collaborator
Author
I aggre to keep the files in this repo is better to test. Thanks for the review. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7467195ee
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
test(sqllogictest): report failure diagnostics
feat(test): support glob run selectors in sqllogictests
Run tests by glob pattern.
databend-sqllogictests --run 'tests/sqllogictests/suites/base/**/*.test'or
databend-sqllogictests --run '**/suites/base/'skip by glob pattern
Tests
Type of change
This change is