Skip to content

feat(test): display query_id on sqllogictest failure#19528

Open
dqhl76 wants to merge 4 commits intodatabendlabs:mainfrom
dqhl76:sqllogic-test-split
Open

feat(test): display query_id on sqllogictest failure#19528
dqhl76 wants to merge 4 commits intodatabendlabs:mainfrom
dqhl76:sqllogic-test-split

Conversation

@dqhl76
Copy link
Collaborator

@dqhl76 dqhl76 commented Mar 11, 2026

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

test(sqllogictest): report failure diagnostics

Summary: ✅ Passed, 1546 test(s) across 53 file(s) completed in 94728 ms.
Summary: ⚠️  No tests were run.
Summary: ❌ Failed, 3 record(s) across 3 file(s); 29 discovered test(s); fail fast enabled; 1.49 s.

Failures:
[tests/sqllogictests/suites/debug_local/failed.test]
  1. query_id: 019ce117656b796089806835e6b68610
     non-default settings:
       sandbox_tenant = OxMuijg (default: (empty), level: SESSION)
     query result mismatch:
     [SQL] select 1
     [Diff] (-expected|+actual)
     -   2
     +   1
     at tests/sqllogictests/suites/debug_local/failed.test:16

[tests/sqllogictests/suites/debug_local/failed2.test]
  1. query_id: 019ce117656b7960898068261a810677
     non-default settings:
       sandbox_tenant = rsRNySl (default: (empty), level: SESSION)
     statement failed: Databend sqllogictests error: http query error: code: 1104, Text: sync crash me
     [SQL] SELECT * FROM sync_crash_me('sync crash me')
     at tests/sqllogictests/suites/debug_local/failed2.test:16

[tests/sqllogictests/suites/debug_local/failed3.test]
  1. query_id: 019ce117659b74c19959aad1e0221266
     non-default settings:
       max_threads = 2 (default: 8, level: SESSION)
       sandbox_tenant = yyHPmah (default: (empty), level: SESSION)
     query result mismatch:
     [SQL] select 3
     [Diff] (-expected|+actual)
     -   4
     +   3
     at tests/sqllogictests/suites/debug_local/failed3.test:19

Databend sqllogictests error: sqllogictest failed

feat(test): support glob run selectors in sqllogictests

Run tests by glob pattern.

databend-sqllogictests --run 'tests/sqllogictests/suites/base/**/*.test'

or

databend-sqllogictests --run '**/suites/base/'

skip by glob pattern

databend-sqllogictests --run 'tests/sqllogictests/suites/base/**/*.test' --skip 'tests/sqllogictests/suites/base/01_system'

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Mar 11, 2026
@sundy-li
Copy link
Member

How to ensure the tests quality for each commit if they were move to another repo?

@dqhl76 dqhl76 force-pushed the sqllogic-test-split branch from 0d4b294 to f746719 Compare March 16, 2026 14:08
@dqhl76 dqhl76 changed the title refactor(test): extract sqllogictest to a separate repository feat(test): display query ID on sqllogictest failure Mar 16, 2026
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Mar 16, 2026
@dqhl76
Copy link
Collaborator Author

dqhl76 commented Mar 16, 2026

How to ensure the tests quality for each commit if they were move to another repo?

I aggre to keep the files in this repo is better to test. Thanks for the review.

@dqhl76 dqhl76 marked this pull request as ready for review March 17, 2026 05:30
@dqhl76 dqhl76 requested review from sundy-li and zhang2014 March 17, 2026 05:30
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7467195ee

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@dqhl76 dqhl76 changed the title feat(test): display query ID on sqllogictest failure feat(test): display query_id on sqllogictest failure Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants