fix: match on uninhabited types at compile time #1401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uninhabited types should be dealt with at compile time, not through the runtime panic that `unreachable!` throws since rust 1.82, Rust has better ergonomics for matching on uninhabited enum variants, which makes this easier for owned types (rust-lang/rust#122792)
drmingdrmer
approved these changes
Aug 4, 2025
There was a problem hiding this comment.
Wow cool! Thank you!
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @drmingdrmer and @SteveLauC)
openraft/src/error.rs line 324 at r1 (raw file):
RPCError::PayloadTooLarge(e) => RPCError::PayloadTooLarge(e), RPCError::Network(e) => RPCError::Network(e), RPCError::RemoteError(_infallible) => unreachable!(),
Oh today I learned that! It does not need to enumerate a variant that can not be constructed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uninhabited types should be dealt with at compile time, not through the runtime panic that
unreachable!throwssince rust 1.82, Rust has better ergonomics for matching on uninhabited enum variants, which makes this easier for owned types (rust-lang/rust#122792)
Checklist
This change is