-
Notifications
You must be signed in to change notification settings - Fork 10
ADD: Add optional chrono feature for date/datetime conversions #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@TheDan64 Is this feature still relevant for you? |
Collaborator
|
Hi @wtn, In order to merge this, I'd want the chrono support to extend to Live with |
threecgreen
reviewed
Dec 4, 2025
threecgreen
reviewed
Dec 4, 2025
threecgreen
reviewed
Dec 4, 2025
threecgreen
reviewed
Dec 4, 2025
4e3d295 to
e6c2400
Compare
threecgreen
reviewed
Dec 4, 2025
threecgreen
reviewed
Dec 4, 2025
Co-authored-by: Claude <[email protected]>
Contributor
Author
|
Thanks, addressed feedback and fixed the |
Collaborator
|
Committed in 6eb1d48. Thanks again! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #21.
Adds optional
chronofeature flag that enables conversions fromchronodate and datetime types toDateRangeandDateTimeRange.Changes
chronoas an optional dependency (>=0.4.34, minimal features:alloconly)Fromtraits forDateTimeRange:Range<DateTime<Tz>>andRangeInclusive<DateTime<Tz>>(generic over timezone)(DateTime<Tz>, DateTime<Tz>)tuple(DateTime<Tz>, chrono::Duration)tupleNaiveDate,Range<NaiveDate>,RangeInclusive<NaiveDate>,(NaiveDate, NaiveDate)Fromtraits forDateRange:NaiveDate,Range<NaiveDate>,RangeInclusive<NaiveDate>,(NaiveDate, NaiveDate)Usage
Type of change
Please delete options that are not relevant.
How has this change been tested?
cargo test --features chrono chrono_tests- 14 new tests for chrono conversions./scripts/test.sh- all 50 tests pass (includes chrono tests)cargo test(without chrono feature) - 36 existing tests still passChecklist
scripts/build.sh)scripts/lint.shandscripts/format.sh)scripts/test.sh)Declaration
I confirm this contribution is made under an Apache 2.0 license and that I have the authority
necessary to make this contribution on behalf of its copyright owner.