Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the 0.10.5 release by updating version metadata, improving usage statistical uploads, and upgrading ECS deployment actions in CI.
- Switched
printto_LOGGER.infoinupload_usage, added error handling, and reset usage metadata. - Modified the
count_requestsdecorator to call the wrapped function once and return its result. - Bumped version to 0.10.5 and updated ECS deploy actions from v1 to v2 in workflows.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| bedhost/main.py | Replaced stdout print with logger, wrapped usage upload in try/except |
| bedhost/helpers.py | Refactored decorator to store and return the function result |
| bedhost/_version.py | Updated package version to 0.10.5 |
| .github/workflows/deploy-api.yml | Upgraded amazon-ecs-deploy-task-definition action to v2 |
| .github/workflows/deploy-api-dev.yml | Upgraded amazon-ecs-deploy-task-definition action to v2 |
Comments suppressed due to low confidence (2)
bedhost/helpers.py:98
- [nitpick] The name
function_resultis generic. Consider renaming it toresultorresponsefor clarity.
function_result = await func(*args, **kwargs)
bedhost/helpers.py:98
- Calling the wrapped function before computing usage metrics means errors there will skip metric tracking. If metrics must run regardless of success, move this call into a
try/finallyor callfuncafter the metric logic.
function_result = await func(*args, **kwargs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
TODO:
__version__.pyfile