Skip to content

Comments

fix: logging utils cleanup and document#297

Open
RemoteRabbit wants to merge 13 commits intodatabricks-industry-solutions:mainfrom
RemoteRabbit:fix/logging-utils
Open

fix: logging utils cleanup and document#297
RemoteRabbit wants to merge 13 commits intodatabricks-industry-solutions:mainfrom
RemoteRabbit:fix/logging-utils

Conversation

@RemoteRabbit
Copy link
Contributor

Summary

Cleanup the logging util by removing duplicated and redundant calls. Update with better docstring definitions and type annotations.

✨ Features

  • feat: setup base type annotations [636826a]
  • feat: add fallback logging to info [5a79b0d]

🐛 Bug Fixes

  • fix: remove duplicate log format, reuse just the one [521918b]
  • fix: convert logger.handlers loop to not to be more pythonic [33609a0]
  • fix: removed redendant file creation as FileHandler takes care of that [d0f8ce9]
  • fix: replace long elif block with a getattr to get log level [23c173a]
  • fix: converted basePath to PEP standard for snake case base_path [f5c9f22]
  • fix: remove unused pylint disable [04e0b8f]
  • fix: clean unused imports [ebc4b43]

📚 Documentation

🔧 Maintenance

📁 File Changes

Securityanalysistoolproject (+86/-48 lines)

  • src/securityanalysistoolproject/core/logging_utils.py (+86/-48) 📝

Changes: 1 files, +86 insertions, -48 deletions
Commits: 11
Branch: fix/logging-utils
Base: origin/main

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation Update (non-code changes like README or docs)

Checklist

  • I have reviewed the CONTRIBUTING and VERSIONING documentation.
  • My code follows the code style of this project.
  • I have verified, added or updated the tests to cover my changes (if applicable).
  • I have verified that my changes do not introduce any breaking changes on all the supported clouds (AWS, Azure, GCP).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@RemoteRabbit RemoteRabbit changed the title Fix/logging utils fix: logging utils cleanup and document Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants