Skip to content

Implementing case insensitive checks for format options #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implementing case insensitive checks for format options #122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09ab603
Implementing case insensitive checks for format options
jon-gao-db Nov 6, 2025
1008e4c
Fixing format issues with whitespace
jon-gao-db Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions ...emplates/file-push/template/{{.catalog_name}}.{{.schema_name}}/src/utils/formatmanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,26 +39,33 @@ def get_userfacing_options(self) -> dict[str, str]:

def validate_user_options(self, options: dict[str, str]) -> None:
allowed = set(self.get_userfacing_options())
illegal = set(options) - allowed
# Create lowercase version of allowed options for case-insensitive comparison
allowed_lower = {key.lower() for key in allowed}

# Check for illegal options (case-insensitive)
illegal = [key for key in options if key.lower() not in allowed_lower]

if illegal:
raise ValueError(
f"Unsupported or protected options: {sorted(illegal)}. "
f"Allowed user options: {sorted(allowed)}"
)

def get_modified_options(self, options: dict[str, str]) -> dict[str, str]:
self.validate_user_options(options)
defaults = self.get_userfacing_options()
return {k: v for k, v in options.items() if k in defaults and v != defaults[k]}

def get_merged_options(
self, options: dict[str, str], table_name: str, is_placeholder: bool = False
) -> dict[str, str]:
self.validate_user_options(options)
defaults = {opt.key: opt.value for opt in self.options}
# Create case-insensitive mapping
defaults_lower = {key.lower(): key for key in defaults}

merged = defaults.copy()
merged.update({k: v for k, v in options.items() if k in defaults})
# Merge user options using case-insensitive matching
for user_key, user_value in options.items():
lower_key = user_key.lower()
if lower_key in defaults_lower:
canonical_key = defaults_lower[lower_key]
merged[canonical_key] = user_value

# Do not specify schema evolution mode in placeholder
if is_placeholder:
Expand Down