Commit 0a1a309
authored
Show a warning message if a resource is not in GroupToTerraformName (#3463)
## Why
<!-- Why are these changes needed? Provide the context that the reviewer
might be missing.
For example, were there any decisions behind the change that are not
reflected in the code itself? -->
When introducing a new resource to the system it does not get a mention
in the plan automatically. Instead, developer must know that the new
resource has to be added to the GroupToTerraformName map for it. The
warning message is a good indicator for the developer of the new
resource that an extra step is needed for the resource support. I opted
for the warning message instead of panicking because apparently there
are resources that do not need to be in the plan, but there is no
comprehensive list of such resources provided and I am not sure that the
test suite covers every such resource, it is not a great experience for
the bundle operation to be blocked just because the resource is in
neither of the lists.
## Tests
<!-- How have you tested the changes? -->
Existing tests are green
<!-- If your PR needs to be included in the release notes for next
release,
add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->1 parent 15ae8ef commit 0a1a309
2 files changed
+15
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
11 | 20 | | |
12 | 21 | | |
13 | | - | |
| 22 | + | |
14 | 23 | | |
15 | 24 | | |
16 | 25 | | |
| |||
34 | 43 | | |
35 | 44 | | |
36 | 45 | | |
37 | | - | |
38 | | - | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
39 | 49 | | |
40 | 50 | | |
41 | 51 | | |
| |||
59 | 69 | | |
60 | 70 | | |
61 | 71 | | |
62 | | - | |
| 72 | + | |
63 | 73 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
0 commit comments