Update target references to use ${bundle.target}

[pietern]

Changes

The built-in template contains a reference to ${bundle.environment}.

This property has been deprecated in favor of ${bundle.target} a long time ago (#670), so we should no longer emit it. The environment field will continue to be usable until we cut a new major version in some far away future.

Tests

• Unit tests
• The test TestInterpolationWithTarget still covers correct interpolation of ${bundle.environment}

[github-actions]

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

• PR number: 1935
• Commit SHA: 96feb14d467e8f4a9f87f8c78e84d9c1d3b465d8

Checks will be approved automatically on success.

[eng-dev-ecosystem-bot]

Test Details: go/deco-tests/12048444439

[pietern]

Existing test:

cli/bundle/tests/interpolation_test.go

Lines 24 to 33 in 96feb14

	func TestInterpolationWithTarget(t *testing.T) {
	b := loadTarget(t, "./interpolation_target", "development")
	diags := bundle.Apply(context.Background(), b, mutator.ResolveVariableReferences(
	"bundle",
	"workspace",
	))
	require.NoError(t, diags.Error())
	assert.Equal(t, "foo bar", b.Config.Bundle.Name)
	assert.Equal(t, "foo bar | bar | development | development", b.Config.Resources.Jobs["my_job"].Name)
	}

Configuration:

cli/bundle/tests/interpolation_target/databricks.yml

Lines 11 to 14 in 96feb14

	resources:
	jobs:
	my_job:
	name: "${bundle.name} | ${workspace.profile} | ${bundle.environment} | ${bundle.target}"