Enable gofumpt in vscode #2001
Merged
Enable gofumpt in vscode #2001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Test Details: go/deco-tests/12293957509 |
pietern
reviewed
Dec 12, 2024
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
Is there a requirement for a particular gopls version to make this work?
| "go.lintFlags": [ | ||
| "--fast" | ||
| ], | ||
| "go.useLanguageServer": true, |
Contributor
There was a problem hiding this comment.
This is the default, not needed AFAIK.
pietern
approved these changes
Dec 12, 2024
Contributor
Author
It is supported since 2020, so should not be a concern golang/tools@62a0bb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests
Verified that with this setting, VSCode reformats code on Save according to gofumpt rules.